Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SBOM reports #269

Merged
merged 12 commits into from
Oct 3, 2024
Merged

SBOM reports #269

merged 12 commits into from
Oct 3, 2024

Conversation

filip-debricked
Copy link
Collaborator

No description provided.

@filip-debricked filip-debricked self-assigned this Sep 26, 2024
@filip-debricked filip-debricked marked this pull request as draft September 26, 2024 15:06
@filip-debricked filip-debricked force-pushed the 0-add-sbom-generation branch 3 times, most recently from 2983551 to c585d92 Compare September 30, 2024 09:35
@filip-debricked filip-debricked added the enhancement New feature or request label Sep 30, 2024
@filip-debricked filip-debricked marked this pull request as ready for review September 30, 2024 09:38
klaradebricked
klaradebricked requested changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@klaradebricked klaradebricked left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some grammar/language comments for correctness and consistency, otherwise LGTM

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: +0.00 (9.00 -> 9.00)

  • Declining Code Health: 4 findings(s) 🚩

  • Affected Hotspots: 3 files(s) 🔥

View detailed results in CodeScene

🚩 Declining Code Health (highest to lowest):

  • Code Duplication report_test.go
  • Code Duplication scanner_test.go 🔥
  • Large Method scan.go: NewScanCmd 🔥
  • Complex Method scanner.go: scan 🔥

sweoggy
sweoggy approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@sweoggy sweoggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks!

@sweoggy sweoggy merged commit 684f2eb into main Oct 3, 2024
17 of 18 checks passed
@sweoggy sweoggy deleted the 0-add-sbom-generation branch October 3, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klaradebricked klaradebricked klaradebricked approved these changes

@sweoggy sweoggy sweoggy approved these changes

Assignees

@filip-debricked filip-debricked

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filip-debricked @sweoggy @klaradebricked